Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: GlasgowEmbedded/glasgow
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 48eed4260bea
Choose a base ref
...
head repository: GlasgowEmbedded/glasgow
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c3dee7d6a1eb
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Sep 29, 2019

  1. aplet.audio.yamaha_opl: raise chunk size.

    Chunk size being too low has caused latency issues.
    whitequark committed Sep 29, 2019
    Copy the full SHA
    8fbad05 View commit details
  2. Copy the full SHA
    c3dee7d View commit details
Showing with 3 additions and 3 deletions.
  1. +1 −1 software/glasgow/applet/audio/yamaha_opl/__init__.py
  2. +2 −2 software/glasgow/applet/audio/yamaha_opl/index.html
2 changes: 1 addition & 1 deletion software/glasgow/applet/audio/yamaha_opl/__init__.py
Original file line number Diff line number Diff line change
@@ -626,7 +626,7 @@ async def play(self):
await self._opx_iface.wait_clocks(self.clock_rate)
await self._opx_iface.disable()

async def record(self, queue, chunk_count=2048):
async def record(self, queue, chunk_count=16384):
total_count = int(self._reader.total_seconds / self.sample_time)
done_count = 0
while done_count < total_count:
4 changes: 2 additions & 2 deletions software/glasgow/applet/audio/yamaha_opl/index.html
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ <h1>Yamaha OP* Web Gateway</h1>
Pull requests welcome.
-->
<script type="text/javascript">
var BUFFER_AT_LEAST = 30;
var BUFFER_AT_LEAST = 8;

function PCMPlayer() {
this.complete = false;
@@ -291,7 +291,7 @@ <h1>Yamaha OP* Web Gateway</h1>
player.loop = loopCheckbox.checked;
}

var socketUrl = new URL("/vgm", window.location.href);
var socketUrl = new URL("vgm", window.location.href);
socketUrl.protocol = socketUrl.protocol.replace("http", "ws");
var socket = new WebSocket(socketUrl);
socket.binaryType = "arraybuffer";