Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

z-lua: substitute lua+lfs for interpreter, fix lfs #68920

Closed
wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 16, 2019

Motivation for this change

I thought this was already accomplished (sorry! :(), but wrapping doesn't work
since z-lua exports the interpreter as $ZLUA_LUAEXE which it uses to
invoke itself from the various shell init / hooks.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @marsam

@marsam
Copy link
Contributor

marsam commented Sep 21, 2019

Sorry for the delay. I think we better wrap LUA_CPATH ourselves instead of using withPackages; would you mind trying marsam@27b119f92cc? this also fix an issue with darwin #23018

@marsam marsam mentioned this pull request Sep 27, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants