Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud: 16.0.5 -> 17.0.0 #69636

Merged
merged 1 commit into from Oct 8, 2019
Merged

nextcloud: 16.0.5 -> 17.0.0 #69636

merged 1 commit into from Oct 8, 2019

Conversation

cw789
Copy link
Contributor

@cw789 cw789 commented Sep 27, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @schneefux @bachp @globin @fpletz

@cw789
Copy link
Contributor Author

cw789 commented Sep 27, 2019

It currently breaks my installation as the apps won't work anymore.
Of every active app .../appinfo/info.xml min-version needs to be at lest 16 - doesn't work if it 17.

@Vskilet Vskilet mentioned this pull request Sep 30, 2019
10 tasks
@globin
Copy link
Member

globin commented Oct 1, 2019

This PR is conflicting, could you please rebase?

@cw789 cw789 changed the title nextcloud: 16.0.4 -> 17.0.0 nextcloud: 16.0.5 -> 17.0.0 Oct 3, 2019
@cw789
Copy link
Contributor Author

cw789 commented Oct 3, 2019

This PR is conflicting, could you please rebase?

Should be ok now.

PS: The thing with the non working apps I think was to due having maintenance mode set during my update.

@globin
Copy link
Member

globin commented Oct 3, 2019

Nope seems something went wrong

@cw789
Copy link
Contributor Author

cw789 commented Oct 4, 2019

Sorry, my fault.

@globin globin merged commit 03ba735 into NixOS:master Oct 8, 2019
@cw789 cw789 deleted the update_nextcloud branch October 8, 2019 06:45
@dtzWill
Copy link
Member

dtzWill commented Oct 8, 2019

Please always look at the deployment notes, they change in minor ways across major updates. Here's what I ended up with for updating the NixOS module: f422c75 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants