add pdfrw and pagelabels #69637
add pdfrw and pagelabels #69637
Conversation
|
@GrahamcOfBorg build termpdfpy |
teto
force-pushed
the
pagelabels
branch
2 times, most recently
from
3de3b06
to
357e136
Compare
|
@GrahamcOfBorg build termpdfpy |
|
@GrahamcOfBorg eval |
|
you look a bit bored @jonringer, don't you ? don't worry I have thought about you and prepared this PR just in case :p |
| }; | ||
|
|
||
| # no python3 support yet | ||
| doCheck = false; |
There was a problem hiding this comment.
if the comment is true, then this should work
| doCheck = false; | |
| doCheck = isPy27; |
There was a problem hiding this comment.
turns out that there are even more errors with python2 so I just disabled for both as originally ( I had not tested python2 at the time)
There was a problem hiding this comment.
there should be an attempt to run all the pure tests that you can. There will be some that you can't do in a sandbox environment, but we want to guarentee that the package wont break when your dependencies get bumped.
There was a problem hiding this comment.
it requires additionnal pdfs https://github.com/pmaupin/pdfrw#6testing . I think it's fine to disable them. The decision can be revisited when and if the package breaks.
|
isPy27 needs to be added to the top of the file, and please squash the commits :) |
|
@GrahamcOfBorg build python27Packages.pagelabels python27Packages.pdfrw python37Packages.pagelabels python37Packages.pdfrw termpdfpy |
|
not sure if this intended behavior: |
|
It is, it only works with the kitty terminal for now but is pretty impressive nonetheless (can select and youank from a pdf in a terminal - if it's kitty) |
| }; | ||
|
|
||
| # no python3 support yet | ||
| doCheck = false; |
There was a problem hiding this comment.
there should be an attempt to run all the pure tests that you can. There will be some that you can't do in a sandbox environment, but we want to guarentee that the package wont break when your dependencies get bumped.
Used in termpdf I want to package.
This is a pdf reader for the terminal kitty.
Motivation for this change
I want to package https://github.com/dsanson/termpdf.py (I have but there is an issue when importing fitz so termpdf.py update will be delayed until I fix it).
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @