Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackage.datatable: 0.8.0 -> 0.9.0 #68716

Merged
merged 1 commit into from Sep 29, 2019
Merged

pythonPackage.datatable: 0.8.0 -> 0.9.0 #68716

merged 1 commit into from Sep 29, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 13, 2019 •
edited

Motivation for this change

#68361

bumped version while fixing build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[3 built (1 failed), 43 copied (736.8 MiB), 101.5 MiB DL]
error: build of '/nix/store/x1594jhpklc5ch3snxqgh6sbr3l9pbw7-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/68716
1 package failed to build:
python37Packages.optuna

3 package were build:
python37Packages.dask-xgboost python37Packages.datatable python37Packages.xgboost

optuna is broken by lightgbm which is addressed here: #68719

@ofborg ofborg bot requested a review from abbradar September 13, 2019 23:50
@d-goldin
Copy link
Contributor

d-goldin commented Sep 28, 2019 •
edited

I briefly started looking into this since it still shows up as one of the "top" failures for 19.09 and can confirm that the version upgade solves the cause of the failure. I also gave the build a run on nixos and it works for me. I can't say much for the removing of the compiler monkeypatching for darwin though. We should bump this PR.

@jonringer
Copy link
Contributor Author

@marsam @Ma27 this still needs merge and backport for master/19.09

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.dask-xgboost python37Packages.datatable python37Packages.optuna python37Packages.xgboost

i rebased off current master, and did nix-review again

https://github.com/NixOS/nixpkgs/pull/68716
4 package were build:
python37Packages.dask-xgboost python37Packages.datatable python37Packages.optuna python37Packages.xgboost

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.dask-xgboost python37Packages.datatable python37Packages.optuna python37Packages.xgboost

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 29, 2019
@Ma27 Ma27 self-assigned this Sep 29, 2019
@Ma27 Ma27 merged commit 1eea42f into NixOS:master Sep 29, 2019
@jonringer jonringer deleted the bump-datatable branch September 29, 2019 01:36
@Ma27
Copy link
Member

Ma27 commented Sep 29, 2019

Backported as 3f25baa.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 29, 2019
@abbradar
Copy link
Member

abbradar commented Oct 3, 2019

Thanks for taking care of this one!

@korayal
Copy link

korayal commented Oct 10, 2019 •
edited

Was this tested for darwin?

I had to make some changes ( korayal@9580b8d ) to make this work on Mac OS X 10.14.6

@jonringer
Copy link
Contributor Author

Tested? no. I just run NixOS

@the-alex
Copy link

the-alex commented Apr 14, 2020 •
edited

@korayal would you make a PR for this? I just managed to get this compiling on macOS Mojave 10.14.6. If you don't want to, I can throw one up, but I don't want to be redundant. Your fork here was instrumental in getting my patch to work too, so kudos 🎉

xgboost has a single test dependency on datatables that causes it to fail on macOS and this has been bugging me for a while.

@korayal
Copy link

korayal commented Apr 14, 2020

@the-alex glad that it worked for you. Unfortunately, because of the current situation I do not have the means to maintain MacOS support for this code. So I'm OK with you making a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@abbradar abbradar Awaiting requested review from abbradar

Assignees

@Ma27 Ma27

Labels
6.topic: python 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jonringer @d-goldin @Ma27 @abbradar @korayal @the-alex