Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpPackages.phpcs: 3.4.2 -> 3.5.0 #69941

Merged
merged 1 commit into from Sep 29, 2019
Merged

phpPackages.phpcs: 3.4.2 -> 3.5.0 #69941

merged 1 commit into from Sep 29, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 29, 2019 •
edited

Motivation for this change

https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.5.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ma27 Ma27 requested a review from etu September 29, 2019 01:28
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 29, 2019
@ofborg ofborg bot requested a review from javaguirre September 29, 2019 01:57
@etu etu merged commit 195da9d into NixOS:master Sep 29, 2019
@Ma27 Ma27 deleted the bump-phpcs branch September 29, 2019 10:23
@etu etu mentioned this pull request Sep 29, 2019
Merged
10 tasks
@etu
Copy link
Contributor

etu commented Sep 29, 2019

@Ma27 Mind updating phpcbf as well? It's from the same project :)

@Ma27 Ma27 mentioned this pull request Sep 29, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu Awaiting requested review from etu

@javaguirre javaguirre Awaiting requested review from javaguirre

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ma27 @etu