-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarissa: init at 1.0-80-g00c2581 #69660
base: master
Are you sure you want to change the base?
Conversation
I'm not sure if we want to include tools in nixpkgs that probably just have a single user, since there's a non-zero cost to including new packages, namely maintenance, hydra build time and for NixOS modules it even slows down everybody's Maybe NUR is a better place to put such packages, or eventually as Flakes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
references to pkgs should be unnecessary
cc @infinisil for his module knowledge
EDIT: you already commented, lol
e8f5ca8
to
fb91a59
Compare
reopened in honour of the 1st anniversary of the v1 release 4 years ago |
converted to draft until the test can be sorted out
|
0011315
to
5d5f1c5
Compare
actually waiting for the ping to succeed seems to be enough for the other machine's hostname to show up ideally i'd get the addresses out of the other machine and check for those, but this will do as a basic test |
i'm intentionally ignoring the failing |
@evils See https://github.com/NixOS/nixpkgs/tree/master/pkgs/by-name#recommendation-for-new-packages-with-multiple-versions then to resolve the CI failure. |
@infinisil huh, thanks, i didn't think to look there because i didn't know by-name was now a requirement the recommendation there does not provide enough context for me to be able to use it |
e8622e6
to
55637b1
Compare
pkgs/top-level/all-packages.nix
Outdated
clarissa = callPackage ../tools/networking/clarissa { }; | ||
clar = callPackage ../tools/networking/clarissa/clar.nix { }; | ||
clar-oui = callPackage ../tools/networking/clarissa/oui.nix { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply, this will work:
clarissa = callPackage ../tools/networking/clarissa { }; | |
clar = callPackage ../tools/networking/clarissa/clar.nix { }; | |
clar-oui = callPackage ../tools/networking/clarissa/oui.nix { }; | |
inherit ({ | |
clarissa = callPackage ../tools/networking/clarissa { }; | |
clar = callPackage ../tools/networking/clarissa/clar.nix { }; | |
clar-oui = callPackage ../tools/networking/clarissa/oui.nix { }; | |
}) clarissa clar clar-oui; |
Motivation for this change
I want to share my tool.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)36910136