Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud-client: 2.5.3 -> 2.6.0 #69743

Merged
merged 1 commit into from Oct 17, 2019
Merged

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 28, 2019

Motivation for this change

https://github.com/nextcloud/desktop/releases/tag/v2.6.0

(Before merging this, I'd like to have a few more testers though).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
executables seem to work (just tested usage statements)
leaf package

[3 built, 82 copied (403.7 MiB), 93.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/69743
1 package were build:
nextcloud-client

@Ma27
Copy link
Member Author

Ma27 commented Oct 2, 2019

Any further testers? Otherwise I'd merge tomorrow.

@jtojnar
Copy link
Contributor

jtojnar commented Oct 2, 2019

Sorry, still did not find time to deploy a Nextcloud instance.

@jonringer
Copy link
Contributor

there's a few nextcloud nixos tests, but I don't think they include any client logic. May be nice to add another to verify that the most common scenarios are supported.

@Ma27
Copy link
Member Author

Ma27 commented Oct 11, 2019

@jtojnar do you still need a Nextcloud instance for testing purposes? If you lack time to do this, I could create a temporary Nextcloud setup on one of my servers :)

@jtojnar
Copy link
Contributor

jtojnar commented Oct 11, 2019

@Ma27 Hosting my own Nextcloud instance is on my to-do list. Deploying such a moloch declaratively will be ton of work, though. Or maybe I could use https://github.com/aszlig/avonc.

@teto
Copy link
Member

teto commented Oct 16, 2019

I lost my own instance during a nixpkgs update, I've registered to qcloud which worked yesterday but today, it shows "user disabled" when I try to login (in a browser). Otherwise the client builds and seems to run fine, I just couldn't test everything yet.

@Ma27
Copy link
Member Author

Ma27 commented Oct 16, 2019

I lost my own instance during a nixpkgs update

May I ask what exactly went wrong? Although Nextcloud has its quirks, the NixOS module seems rather stable to me :)

I've registered to qcloud which worked yesterday but today, it shows "user disabled" when I try to login (in a browser).

yeah, they actually changed the login flow to do browser logins (so you don't have to enter your credentials every time if the login is remembered by the browser). But, as I've found several results to qcloud, would you mind telling me which one you mean?

Also, is this compatible to nextcloud (and is the error therefore relevant?).

@teto
Copy link
Member

teto commented Oct 17, 2019

I have no idea how my nextcloud db got deleted but this was a test server, I might have tried a nextcloud PR that was not ready yet or something completely different.
I solved the login issue with qloud.my (a nextcloud provider) and the client synchronizes correctly.
So feel free to merge.

@flokli flokli merged commit f842ba3 into NixOS:master Oct 17, 2019
@Ma27 Ma27 deleted the bump-nextcloud-client branch October 17, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants