-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nextcloud-client: 2.5.3 -> 2.6.0 #69743
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix-review
passes on NixOS
executables seem to work (just tested usage statements)
leaf package
[3 built, 82 copied (403.7 MiB), 93.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/69743
1 package were build:
nextcloud-client
Any further testers? Otherwise I'd merge tomorrow. |
Sorry, still did not find time to deploy a Nextcloud instance. |
there's a few nextcloud nixos tests, but I don't think they include any client logic. May be nice to add another to verify that the most common scenarios are supported. |
@jtojnar do you still need a Nextcloud instance for testing purposes? If you lack time to do this, I could create a temporary Nextcloud setup on one of my servers :) |
@Ma27 Hosting my own Nextcloud instance is on my to-do list. Deploying such a moloch declaratively will be ton of work, though. Or maybe I could use https://github.com/aszlig/avonc. |
I lost my own instance during a nixpkgs update, I've registered to qcloud which worked yesterday but today, it shows "user disabled" when I try to login (in a browser). Otherwise the client builds and seems to run fine, I just couldn't test everything yet. |
May I ask what exactly went wrong? Although Nextcloud has its quirks, the NixOS module seems rather stable to me :)
yeah, they actually changed the login flow to do browser logins (so you don't have to enter your credentials every time if the login is remembered by the browser). But, as I've found several results to Also, is this compatible to nextcloud (and is the error therefore relevant?). |
I have no idea how my nextcloud db got deleted but this was a test server, I might have tried a nextcloud PR that was not ready yet or something completely different. |
Motivation for this change
https://github.com/nextcloud/desktop/releases/tag/v2.6.0
(Before merging this, I'd like to have a few more testers though).
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @