Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

anydesk: 4.0.1 -> 5.1.2 #69712

Merged
merged 2 commits into from Oct 7, 2019
Merged

anydesk: 4.0.1 -> 5.1.2 #69712

merged 2 commits into from Oct 7, 2019

Conversation

shyim
Copy link
Member

@shyim shyim commented Sep 27, 2019

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peterhoeg

@ofborg ofborg bot requested a review from peterhoeg September 27, 2019 23:09
@peterhoeg
Copy link
Member

Thanks for this @shyim. Do you feel like adding yourself as maintainer (and removing me as I don't use this)?

@shyim
Copy link
Member Author

shyim commented Sep 29, 2019

@peterhoeg sure :). Changed the maintainers and removed you :)

@peterhoeg
Copy link
Member

Thank you for taking this on. Lastly - please split the change where you add yourself to the maintainers/maintainer-list.nix file into a separate commit.

@shyim
Copy link
Member Author

shyim commented Sep 29, 2019

Its now in two commits :)

@jonringer
Copy link
Contributor

if you could switch the order of the commits, otherwise if we checkout bf940bc, anydesk will fail to evaluate :/

@shyim
Copy link
Member Author

shyim commented Oct 1, 2019

Changed order @jonringer hopefully everything is now okay 😅

@peterhoeg peterhoeg merged commit 520a658 into NixOS:master Oct 7, 2019
@shyim shyim deleted the update-anydesk branch October 7, 2019 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shyim @peterhoeg @jonringer