Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osm2pgsql: 0.96.0 -> 1.0.0 #69716

Merged
merged 2 commits into from Oct 13, 2019
Merged

osm2pgsql: 0.96.0 -> 1.0.0 #69716

merged 2 commits into from Oct 13, 2019

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/osm2pgsql/versions.

meta.description for osm2pgsql is: '"OpenStreetMap data to PostgreSQL converter"'.

meta.homepage for osm2pgsql is: '"https://github.com/openstreetmap/osm2pgsql"

Compare changes on GitHub

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
osm2pgsql

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/cq1xgnb2qkiq59lw22i4cddg9861svbn-osm2pgsql-1.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A osm2pgsql https://github.com/r-ryantm/nixpkgs/archive/9e431e1f5156062ecb9691487d64d33ddcaee6b2.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/cq1xgnb2qkiq59lw22i4cddg9861svbn-osm2pgsql-1.0.0
ls -la /nix/store/cq1xgnb2qkiq59lw22i4cddg9861svbn-osm2pgsql-1.0.0/bin

@r-ryantm
osm2pgsql: 0.96.0 -> 1.0.0
9e431e1 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/osm2pgsql/versions
@jglukasik
Copy link
Contributor

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64
  • executables tested on x86_64
  • all depending packages build
Possible improvements

meta.maintainers is not set. I volunteer myself to be the maintainer for this package, if a committer can make that change for me.

Comments

I was successfully able to import a small regional OSM file to a local postgres+postgis database with the binary build with this expression.

Output for the curious: 
[nix-shell:~/osm]$ nix-build -A osm2pgsql /home/jgl/repos/nixpkgs
/nix/store/cq1xgnb2qkiq59lw22i4cddg9861svbn-osm2pgsql-1.0.0
 
[nix-shell:~/osm]$ uname -m
x86_64

[nix-shell:~/osm]$ /nix/store/cq1xgnb2qkiq59lw22i4cddg9861svbn-osm2pgsql-1.0.0/bin/osm2pgsql norcal-latest.osm.pbf
osm2pgsql version 1.0.0 (64 bit id space)

Allocating memory for dense node cache
Allocating dense node cache in one big chunk
Allocating memory for sparse node cache
Sharing dense sparse
Node-cache: cache=800MB, maxblocks=12800*65536, allocation method=3                                                 
Using built-in tag processing pipeline
Using projection SRS 3857 (Spherical Mercator)
Setting up table: planet_osm_point
Setting up table: planet_osm_line
Setting up table: planet_osm_polygon
Setting up table: planet_osm_roads

Reading in file: norcal-latest.osm.pbf
Using PBF parser.
Processing: Node(44597k 4955.3k/s) Way(3799k 42.21k/s) Relation(35680 5097.14/s)  parse time: 106s                  
Node stats: total(44597370), max(6791378270) in 9s
Way stats: total(3799172), max(724147018) in 90s
Relation stats: total(37432), max(10032569) in 7s
node cache: stored: 44597370(100.00%), storage efficiency: 54.43% (dense blocks: 2194, sparse nodes: 31981377), hit r
ate: 100.00%
Sorting data and creating indexes for planet_osm_line
Sorting data and creating indexes for planet_osm_roads
Sorting data and creating indexes for planet_osm_point
Sorting data and creating indexes for planet_osm_polygon
Copying planet_osm_roads to cluster by geometry finished
Creating geometry index on planet_osm_roads
Copying planet_osm_point to cluster by geometry finished
Creating geometry index on planet_osm_point
Creating indexes on planet_osm_roads finished
All indexes on planet_osm_roads created in 7s
Completed planet_osm_roads
Creating indexes on planet_osm_point finished
All indexes on planet_osm_point created in 39s
Completed planet_osm_point
Copying planet_osm_line to cluster by geometry finished
Creating geometry index on planet_osm_line
Copying planet_osm_polygon to cluster by geometry finished
Creating geometry index on planet_osm_polygon
Creating indexes on planet_osm_line finished
All indexes on planet_osm_line created in 121s
Completed planet_osm_line
Creating indexes on planet_osm_polygon finished
All indexes on planet_osm_polygon created in 154s
Completed planet_osm_polygon
 
Osm2pgsql took 261s overall

jglukasik
jglukasik approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@jglukasik jglukasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(oops, my previous comment was meant to be an approved review!)

@ofborg ofborg bot requested a review from jglukasik October 13, 2019 09:26
@c0bw3b c0bw3b merged commit 132413e into NixOS:master Oct 13, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 13, 2019

@jglukasik you are now listed as maintainer of osm2pgsql :)

@r-ryantm r-ryantm deleted the auto-update/osm2pgsql branch October 20, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@jglukasik jglukasik Awaiting requested review from jglukasik

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r-ryantm @jglukasik @c0bw3b