Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.shodan: 1.14.0 -> 1.17.0 #70017

Merged
merged 1 commit into from Sep 29, 2019
Merged

pythonPackages.shodan: 1.14.0 -> 1.17.0 #70017

merged 1 commit into from Sep 29, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 29, 2019 •
edited

Motivation for this change

noticed it was broken when reviewing an update

closes #69915

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

before:

[nix-shell:~/.cache/nix-review/pr-69915]$ ./results/python37Packages.shodan/bin/shodan --help
Traceback (most recent call last):
  File "/nix/store/ml9d088ac6qp5z1wsg5n4i0vr3fm0my7-python3.7-shodan-1.17.0/bin/.shodan-wrapped", line 7, in <module>
    from shodan.__main__ import main
  File "/nix/store/ml9d088ac6qp5z1wsg5n4i0vr3fm0my7-python3.7-shodan-1.17.0/lib/python3.7/site-packages/shodan/__main__.py", line 32, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'

after:

$ ./result/bin/shodan --help
Usage: shodan [OPTIONS] COMMAND [ARGS]...

Options:
  -h, --help  Show this message and exit.
...

[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70017
2 package were build:
python27Packages.shodan python37Packages.shodan

@jonringer jonringer mentioned this pull request Sep 29, 2019
Closed
@ofborg ofborg bot requested a review from lihop September 29, 2019 12:56
@Mic92 Mic92 merged commit 406335a into NixOS:master Sep 29, 2019
@Mic92
Copy link
Member

Mic92 commented Sep 29, 2019

backport:

[detached HEAD 21a8839] pythonPackages.shodan: 1.14.0 -> 1.17.0
Author: Jonathan Ringer jonringer117@gmail.com
Date: Sun Sep 29 05:39:36 2019 -0700
1 file changed, 4 insertions(+), 2 deletions(-)

@jonringer jonringer deleted the bump-shodan branch September 29, 2019 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@lihop lihop Awaiting requested review from lihop

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @Mic92