Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.supervisor: 3.3.5 -> 4.0.4 #70019

Merged
merged 1 commit into from Sep 29, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 29, 2019

Motivation for this change

noticed it needed setuptools when reviewingi #69918

also bumped the version again, and enabled support for python3.

closes #69918

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70019
2 package were build:
python27Packages.supervisor python37Packages.supervisor
[nix-shell:~/.cache/nix-review/pr-70019]$ ./results/python37Packages.supervisor/bin/supervisorctl --help
supervisorctl -- control applications run by supervisord from the cmd line.
...

@Mic92
Copy link
Member

Mic92 commented Sep 29, 2019

backport:

[detached HEAD e1b962d] pythonPackages.supervisor: 3.3.5 -> 4.0.4
Author: Jonathan Ringer jonringer117@gmail.com
Date: Sun Sep 29 05:52:08 2019 -0700
1 file changed, 8 insertions(+), 9 deletions(-)
Press Enter to continue

@jonringer jonringer deleted the bump-supervisor branch September 29, 2019 18:13
@Taneb
Copy link
Contributor

Taneb commented Sep 30, 2019

I can't build this, and it seems neither can Hydra.

@Mic92
Copy link
Member

Mic92 commented Sep 30, 2019

Mhm. I could build this locally:

@GrahamcOfBorg build pythonPackages.supervisor

@Mic92
Copy link
Member

Mic92 commented Sep 30, 2019

@GrahamcOfBorg build python3Packages.supervisor

@Mic92
Copy link
Member

Mic92 commented Sep 30, 2019

Result of nix-review pr 70019 1

2 package were build:
  • python27Packages.supervisor
  • python37Packages.supervisor

@jonringer
Copy link
Contributor Author

I was able to build this locally on master. Interesting that it's not able to open /dev/stdout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants