Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r19.09] qemu: add patches for CVE-2019-13164 & CVE-2019-14378 #69925

Merged
merged 1 commit into from
Oct 27, 2019
Merged

[r19.09] qemu: add patches for CVE-2019-13164 & CVE-2019-14378 #69925

merged 1 commit into from
Oct 27, 2019
+10 −0

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 28, 2019

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-14378
https://nvd.nist.gov/vuln/detail/CVE-2019-13164

master is fine, having 4.1.0. Luckily debian has patches that work against 4.0.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@ofborg ofborg bot requested a review from edolstra September 28, 2019 23:32
@risicle risicle marked this pull request as ready for review September 29, 2019 00:43
@risicle
Copy link
Contributor Author

risicle commented Oct 27, 2019

Can't remember if I have permissions to do this, but

@GrahamcOfBorg build qemu

@t184256
Copy link
Contributor

t184256 commented Oct 27, 2019

Smoke testing: The patches apply correctly, building qemu passes, <nixos/tests/simple.nix> executes OK with the patches applied.

Patch review: First patch is, unfortunately, too complicated for me to follow, the second one is trivial and tame.

@ckauhaus ckauhaus merged commit 1475cc7 into NixOS:release-19.09 Oct 27, 2019
@KamilaBorowska
Copy link
Member

I think this may have broke https://hydra.nixos.org/eval/1551163.

@t184256
Copy link
Contributor

t184256 commented Oct 28, 2019

@xfix: I don't think so. I've tried that one and I'm seeing

  • several successes on 1475cc7 and
  • several successes and one failure on 1475cc7^1

@kmcopper kmcopper mentioned this pull request Oct 29, 2019
Merged
10 tasks
@risicle risicle mentioned this pull request Nov 7, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@risicle @t184256 @KamilaBorowska @ckauhaus