Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: xfce4-screensaver: init at 0.1.8 #69705

Closed
wants to merge 1 commit into from

Conversation

symphorien
Copy link
Member

Motivation for this change

I was chasing a bug with xfce4-14 automatic screen locking so I thought it was related to the missing screensaver component. The bug was solved by an upgrade, so the hypothesis was wrong.

It turned out xfce-screensaver password prompt to unlock sometimes flickers which makes it difficult to login again. The error messages I get are unhelpful at best:

pam_warn(xfce4-screensaver:auth): function=[pam_sm_authenticate] flags=0 service=[xfce4-screensaver] terminal=[:0.0] user=[jane] ruser=[<unknown>] rhost=[<unknown>]

Googling yields nothing and https://bugzilla.xfce.org/ seems down so I cannot even file an issue.
Anyhow I spent more time on this than I originally intended and the PR as is as broken. Either someone has an idea to solve the aforementioned problem or we drop the PR or we disable pam support. You still get a nice screensaver but no password prompt to unlock ¯\(ツ)

Things done

tested in a vm

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

and adaptations to xfce4-14 module
@symphorien symphorien changed the title xfce4-screensaver: init at 0.1.8 WIP: xfce4-screensaver: init at 0.1.8 Sep 27, 2019
@worldofpeace
Copy link
Contributor

It seems they allow multiple screenlockers

And xfce4-screensaver can function as a locker as well

So I think it doesn't exactly have to be default enabled if power management is.
Can we make it a separate module?

@symphorien
Copy link
Member Author

Hum I won't really have time to revisit this.

@symphorien symphorien closed this Oct 21, 2019
@symphorien symphorien deleted the xfce-screensaver branch March 21, 2020 18:19
@symphorien symphorien restored the xfce-screensaver branch March 21, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants