WIP: xfce4-screensaver: init at 0.1.8 #69705
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I was chasing a bug with xfce4-14 automatic screen locking so I thought it was related to the missing screensaver component. The bug was solved by an upgrade, so the hypothesis was wrong.
It turned out xfce-screensaver password prompt to unlock sometimes flickers which makes it difficult to login again. The error messages I get are unhelpful at best:
Googling yields nothing and https://bugzilla.xfce.org/ seems down so I cannot even file an issue.
Anyhow I spent more time on this than I originally intended and the PR as is as broken. Either someone has an idea to solve the aforementioned problem or we drop the PR or we disable pam support. You still get a nice screensaver but no password prompt to unlock ¯\(ツ)/¯
Things done
tested in a vm
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @