Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress 3.4.1: Fix files used for verification. #69962

Merged
merged 2 commits into from Oct 31, 2019
Merged

Cypress 3.4.1: Fix files used for verification. #69962

merged 2 commits into from Oct 31, 2019

Conversation

gomain
Copy link
Contributor

@gomain gomain commented Sep 29, 2019 •
edited

Motivation for this change

Cypress 3.4.1 fails to run giving verification errors.
To reproduce:

  1. Install cypress from nixpkgs --> gets version 3.4.1
  2. In project package directory, install cypress with CYPRESS_INSTALL_BINARY=0 npm install cypress@3.4.1
  3. run CYPRESS_RUN_BINARY=`which Cypress` $(npm bin)/cypress open
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from mmahut September 29, 2019 04:23
@gomain gomain mentioned this pull request Sep 29, 2019
Merged
10 tasks
@mmahut
Copy link
Member

mmahut commented Sep 29, 2019

@GrahamcOfBorg build cypress

@bbigras
Copy link
Contributor

bbigras commented Oct 26, 2019

This seems to work fine 👍 . Can you update to 3.5.0?

bbigras
bbigras approved these changes Oct 26, 2019
View reviewed changes
Copy link
Contributor

@bbigras bbigras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It builds and runs fine 👍 thanks

@bbigras
Copy link
Contributor

bbigras commented Oct 28, 2019

@tweber @mmahut anyone of you can review please?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/72

@mmahut
Copy link
Member

mmahut commented Oct 31, 2019

@GrahamcOfBorg build cypress

@mmahut mmahut merged commit 24753c4 into NixOS:master Oct 31, 2019
@bbigras
Copy link
Contributor

bbigras commented Oct 31, 2019

Thank you very much for your time. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbigras bbigras bbigras approved these changes

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gomain @mmahut @bbigras @nixos-discourse @Janik-Haag