Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.opt-einsum: 2.3.2 -> 3.0.1 #69967

Merged
merged 2 commits into from Sep 29, 2019
Merged

python3Packages.opt-einsum: 2.3.2 -> 3.0.1 #69967

merged 2 commits into from Sep 29, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 29, 2019 •
edited

Motivation for this change

saw it was broken, fixed the build, then bumped the python3 version as v3+ dropped support for python2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

pyro-ppl package is broken due to pytorch being broken on master. Which is being addressed #69947

[0 built (2 failed), 0.0 MiB DL]
error: build of '/nix/store/9l85dy86fczxyfpw08nhl50m85ny4kaa-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/69967
2 package failed to build:
python27Packages.pyro-ppl python37Packages.pyro-ppl

2 package were build:
python27Packages.opt-einsum python37Packages.opt-einsum

@ofborg ofborg bot requested a review from teh September 29, 2019 05:26
@FRidh FRidh merged commit 3a63bee into NixOS:master Sep 29, 2019
@jonringer jonringer deleted the fix-opt-einsum branch September 29, 2019 09:26
@jonringer
Copy link
Contributor Author

this was backported to release-19.09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@teh teh Awaiting requested review from teh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh