Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

friture: init at 0.36 #69864

Merged
merged 1 commit into from
Oct 5, 2019
Merged

friture: init at 0.36 #69864

merged 1 commit into from
Oct 5, 2019
+59 −0

Conversation

laikq
Copy link
Contributor

@laikq laikq commented Sep 28, 2019 •
edited
Loading

Note: scipy was not listed in the requirements of setup.py in the repository, but the package won't build without it.

Motivation for this change

Theoretically, it should be possible to "install" Friture via an AppImage. However, I could not get this to work, neither with appimage-run nor appimageTools.wrapType2 (OS Error: PortAudio library not found). Building this package from source requires a lot of machine resources, but at least it works. There are instructions on reducing the package size in setup.py, but I tried to keep the build as simple as possible because I'm a complete newbie to building packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Maintainers

I could of course try to maintain the package, but I was hesitant to add myself to the maintainers list.

Sorry, something went wrong.

@laikq laikq changed the base branch from release-19.03 to master September 29, 2019 08:06
@ofborg ofborg bot added 6.topic: emacs Text editor 6.topic: erlang 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: lua 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: policy discussion 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: ruby labels Sep 29, 2019
@ofborg ofborg bot removed 6.topic: lua 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: policy discussion 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Sep 29, 2019
@Lassulus
Copy link
Member

If you want to maintain this, then please add yourself to the maintainers list in a seperate commit. I think a maintainer for this package would be very much appreciated.
Also, can't we build this with python3Packages instead of python35Packages?

@laikq
Copy link
Contributor Author

laikq commented Sep 29, 2019 •
edited
Loading

Apparently, when I try to build the package with python3Packages, a unittest fails that is trying to run friture/filter_design.py. This module tries to from scipy.misc import factorial, and this import fails. factorial has been moved from scipy.misc to scipy.special in version 1.3.0, and was deprecated since version 1.0.0. It seems like python3Packages uses Python 3.7, which requires SciPy 1.3.0. Using python35Packages fixes this problem for now.

edit: It seems that it's actually not a problem of python3Packages vs python35Packages but nixos-19.03 vs nixos-unstable. I don't know why exactly, but after trying python3Packages the python35Packages version also does not build for me, with the same error. I think because it's not the nixpkgs-style to maintain several (deprecated) versions of SciPy, I could try to create a patch that makes it work.

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Sep 29, 2019
@ttuegel ttuegel removed their request for review September 29, 2019 15:27
@laikq
Copy link
Contributor Author

laikq commented Sep 29, 2019

So, fixed one error, another opened: When I try to run Friture, I get a Qt error à la Could not find the Qt platform plugin "xcb" in "". I think I cleaned up some of my system packages, and somewhere there I had qtbase installed (and now not anymore).

@Lassulus
Copy link
Member

Lassulus commented Oct 4, 2019

ok, I tested it, seems to work fine. Can you squash the commits into one?

@laikq
friture: init at 0.36

Verified

This commit was signed with the committer’s verified signature. The key has expired.
thoughtpolice Austin Seipp
GPG key ID: 25D2038DEB08021D
Expired
Verified
Learn about vigilant mode
a15e17a
@laikq
Copy link
Contributor Author

laikq commented Oct 5, 2019

Yes, it works for me too :)

Lassulus
Lassulus approved these changes Oct 5, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, started friture, analyzed my microphone audio

@Lassulus Lassulus merged commit daac44f into NixOS:master Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus

@edolstra edolstra

@edwtjo edwtjo

@Ericson2314 Ericson2314

@FRidh FRidh

@infinisil infinisil

@matthewbauer matthewbauer

@nbp nbp

@Profpatsch Profpatsch

@rycee rycee

@thoughtpolice thoughtpolice

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@laikq @Lassulus