Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ledger-live-desktop: 1.12.0 -> 1.15.0 #69867

Merged
merged 1 commit into from Sep 28, 2019
Merged

ledger-live-desktop: 1.12.0 -> 1.15.0 #69867

merged 1 commit into from Sep 28, 2019

Conversation

nyanloutre
Copy link
Member

Motivation for this change

Built with appimageTools.wrapType2 instead of wrapping appimage-run

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@nyanloutre
ledger-live-desktop: 1.12.0 -> 1.15.0
3ceb8d5 
built with appimageTools.wrapType2 instead of wrapping appimage-run
@matthewbauer
Copy link
Member

Looks good! Tested locally and works for me. It also looks like it resolved a segfault I had gotten with 1.12.0.

@matthewbauer matthewbauer merged commit 040f103 into NixOS:master Sep 28, 2019
@matthewbauer
Copy link
Member

Cherry picked in 7f8e417

@nyanloutre nyanloutre deleted the ledger_live_desktop_1_15 branch September 29, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nyanloutre @matthewbauer