Add autochanger support to bacula-sd & improving the module in general #69646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wucke13
force-pushed
the
bacula-autochanger-fix
branch
from
42c35e3
to
6461cc9
Compare
wucke13
force-pushed
the
bacula-autochanger-fix
branch
from
6461cc9
to
8316331
Compare
wucke13
requested review from
alyssais,
basvandijk,
cdepillabout,
edolstra,
Ericson2314,
FRidh,
infinisil,
joachifm,
jonringer,
matthewbauer,
nbp,
peti,
ttuegel,
WilliButz and
zimbatm
as code owners
ofborg
bot
added
6.topic: erlang
6.topic: GNOME
ofborg
bot
removed
6.topic: TeX
|
@Lassulus would you mind taking a look at this? |
+ Fixing interrupted descriptions + Added more verbose descriptions + Addded <literal> to the descriptions + uniformly reformated descriptions to break at 80 chars
wucke13
force-pushed
the
bacula-autochanger-fix
branch
from
e42c533
to
c7945c8
Compare
wucke13
changed the title
|
Ping |
|
this should also go to master! otherwise these changes will disappear in 20.03 |
|
Shure! Shall I open a PR for that too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<literal>s to the descriptionsMotivation for this change
I'm not satisfied with the current state of the bacula module. I have almost no expertise on nixos modules and my hope is, that this PR motivates others to help improving the module. Also, this may solve #65805.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @bobvanderlinden @ericsagnes @proteansec
Please give feedback and/or suggestions on how to improve this!