Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parity: 2.5.7 -> 2.5.8, parity-beta: 2.6.2 -> 2.6.3 #68686

Closed
wants to merge 2 commits into from
Closed

parity: 2.5.7 -> 2.5.8, parity-beta: 2.6.2 -> 2.6.3 #68686

wants to merge 2 commits into from

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Sep 13, 2019

Motivation for this change

Update parity to the latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @akru

jonringer
jonringer approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
binaries seem to work
leaf packages

[7 built, 7 copied (11.5 MiB), 3.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68686
2 package were build:
parity parity-beta

@xrelkd xrelkd closed this Sep 28, 2019
@xrelkd xrelkd deleted the update/parity branch September 28, 2019 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akru akru akru approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrelkd @akru @jonringer