Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imagescan: init at 3.59.2 #69894

Closed
wants to merge 1 commit into from
Closed

imagescan: init at 3.59.2 #69894

wants to merge 1 commit into from

Conversation

wucke13
Copy link
Contributor

@wucke13 wucke13 commented Sep 28, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

mmahut
mmahut reviewed Sep 28, 2019
View reviewed changes
pkgs/misc/drivers/imagescan/default.nix Outdated
stdenv.mkDerivation rec {
name = "imagescan-${version}";
version = "3.59.2";
src = fetchgit {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use ``fetchFromGitHub```.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the project is not on github but on gitlab?
https://github.com/utsushi/imagescan has been archived and points towards gitlab.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a fetchFromGitLab function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I didn't knew that! I adjusted accordingly.

@wucke13 wucke13 force-pushed the imagescan branch 2 times, most recently from 19ab7d3 to 199d004 Compare September 29, 2019 11:14
@symphorien
Copy link
Member

It was already packaged in #65223
But maybe you can:

@wucke13
Copy link
Contributor Author

wucke13 commented Sep 30, 2019

Hmmh, that sucks. I'm against calling this package utsushi (as imagescan is both more descriptive and googling epson imagescan yields by far more results than epson utsushi). Though the main executable is called utsushi, which again isn't very consistent.
Also, I have no clue as to why the existing packages uses the epson sources if it does not ship with the epson proprietary plugins (which seems to be the case?).

@symphorien
Copy link
Member

If you want to call it imagescan, please call it imagescanv3. imagescan (not v3) is something completely different also called epkowa. And by the way, sane's list of supported devices calls it epkowa, not imagescan (probably to distinguish it from utsushi).

About using epson's sources: I was unable to run autoreconf on the community sources. But again, if you add yourself as maintainer, please do as you see fit.

@wucke13
Copy link
Contributor Author

wucke13 commented Sep 30, 2019

I don't know what to believe in anymore. Epsons seems to have a proven track of convenient and systematic naming. Ok, I will close this PR and reopen a new one against utsushi, merging my changes into it.

@wucke13 wucke13 closed this Sep 30, 2019
@d-goldin d-goldin mentioned this pull request Oct 1, 2019
Closed
@wucke13
Copy link
Contributor Author

wucke13 commented Oct 1, 2019

Further effort goes into #70160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@markuskowa markuskowa markuskowa left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wucke13 @symphorien @mmahut @markuskowa