Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildbot: 2.4.0 -> 2.4.1 #69731

Merged
merged 1 commit into from Sep 28, 2019
Merged

buildbot: 2.4.0 -> 2.4.1 #69731

merged 1 commit into from Sep 28, 2019

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Updates buildbot to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @nand0p @ryansydnor

@lopsided98
Copy link
Contributor Author

lopsided98 commented Sep 28, 2019 •
edited

@GrahamcOfBorg build buildbot buildbot-full buildbot-ui
@GrahamcOfBorg build python3Packages.buildbot-worker python2Packages.buildbot-worker
The test usually fails on ofborg, but works fine on Hydra and locally.
@GrahamcOfBorg test buildbot

veprbl
veprbl approved these changes Sep 28, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests and nix-review pass on x86_64-linux:

12 package were build:
buildbot buildbot-full buildbot-ui buildbot-worker python27Packages.buildbot-pkg python27Packages.buildbot-worker python37Packages.buildbot-pkg python37Packages.buildbot-plugins.console-view python37Packages.buildbot-plugins.grid-view python37Packages.buildbot-plugins.waterfall-view python37Packages.buildbot-plugins.wsgi-dashboards python37Packages.buildbot-plugins.www

@veprbl veprbl merged commit 31e2429 into NixOS:master Sep 28, 2019
@lopsided98 lopsided98 deleted the buildbot-update branch September 28, 2019 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lopsided98 @veprbl