Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Make some arguments const/const references, where possible #485

Merged
merged 3 commits into from Nov 23, 2019
Merged

WIP Make some arguments const/const references, where possible #485

merged 3 commits into from Nov 23, 2019

Conversation

rpavlik
Copy link
Contributor

@rpavlik rpavlik commented Sep 12, 2019

Found and suggested by clang-tidy.
May help performance by reducing copies,
depending on frequency of call, etc.

I have to go in and fix the Windows build.

rpavlik and others added 3 commits September 11, 2019 13:43
@rpavlik
Make some arguments const/const references, where possible. NFC.
27d2def 
Found and suggested by clang-tidy.
May help performance by reducing copies,
depending on frequency of call, etc.
@whitequark
fix Windows build
20d3ba8
@whitequark
fix windows, try 2
30b2b7b
@whitequark whitequark merged commit e386d40 into solvespace:master Nov 23, 2019
@whitequark
Copy link
Contributor

Thanks! Let me know if any of your other PRs are ready for review.

@rpavlik rpavlik deleted the const branch November 23, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rpavlik @whitequark