Asynchonous shutdown #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulrouget
force-pushed
the
shutdown
branch
from
70bf3ae
to
65fb047
Compare
Manishearth
approved these changes
Sep 17, 2019
|
@bors-servo r=Manishearth |
|
📌 Commit 65fb047 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Sep 17, 2019
Asynchonous shutdown OpenXR shuts down asynchronously. Ideally webxr would intercept the `SessionEnd` event. But for now, I think this will do.
|
☀️ Test successful - checks-travis |
bors-servo
pushed a commit
that referenced
this pull request
Sep 18, 2019
Fix magicleap build failure Regression introduced with #53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenXR shuts down asynchronously.
Ideally webxr would intercept the
SessionEndevent. But for now, I think this will do.