Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use EGL loader #35

Merged
merged 1 commit into from Sep 13, 2019
Merged

Don't use EGL loader #35

merged 1 commit into from Sep 13, 2019

Conversation

jrmuizel
Copy link
Contributor

This seems to make it so having the DLL around is not required.

@jrmuizel
Copy link
Contributor Author

It sounds like servo uses a different dll so this perhaps not what it wants. It seems to fix things for wrench though.

@jdm
Copy link
Member

jdm commented Sep 13, 2019

We do rely on the mozangle DLLs on desktop Windows right now, so this PR would break webgl in that configuration.

@jrmuizel
Copy link
Contributor Author

What should we do instead?

@jdm
Copy link
Member

jdm commented Sep 13, 2019

Let's add a cargo feature that adds the define in build.rs when enabled - that will allow Servo to have the configuration we need and webrender will be able to unblock its builds.

This seems to make it so having the DLL around is not required.
@jdm
Copy link
Member

jdm commented Sep 13, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit f183472 has been approved by jdm

@bors-servo
Copy link
Contributor

⌛ Testing commit f183472 with merge 706a9ba...

bors-servo pushed a commit that referenced this pull request Sep 13, 2019
Don't use EGL loader

This seems to make it so having the DLL around is not required.
@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis, status-appveyor
Approved by: jdm
Pushing 706a9ba to master...

@bors-servo bors-servo merged commit f183472 into servo:master Sep 13, 2019
@jdm
Copy link
Member

jdm commented Sep 13, 2019

Published 0.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants