Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7612 causes multiple news messages to show at once and overlap. #7711

Closed
James103 opened this issue Aug 31, 2019 · 2 comments
Closed

#7612 causes multiple news messages to show at once and overlap. #7711

James103 opened this issue Aug 31, 2019 · 2 comments
Labels
regression It used to work, and now it's broken.
Milestone

Comments

@James103
Copy link
Contributor

James103 commented Aug 31, 2019

Version of OpenTTD

Since #7612 is merged

Expected result

When multiple newspaper messages are shown, they don't overlap.

Actual result

When multiple newspaper messages are shown, they do overlap.

Example 1 (the second news message is still appearing)
image

Example 2 (both news messages have fully appeared)
image

Steps to reproduce

Trigger lots of various newspaper messages, repeating until you get an overlap.
Example 1:

  • Make sure that "opening of industries" newspaper setting is set to "Full" and "accidents/disasters" newspaper setting is set to "Summary".
  • Pause the game.
  • Build a power station.
  • Unpause game, wait a second, pause game.
  • Build 2 trains, make them ignore next signal, and start them.
  • Unpause game, wait a second, pause game.
  • Build a power station.
  • Unpause the game.
  • You will see overlapping news messages. Pressing spacebar closes the most recent/top news message.

Example 2:

@James103 James103 changed the title #7612 causes multiple news messages show at once and overlap. #7612 causes multiple news messages to show at once and overlap. Aug 31, 2019
@nielsmh nielsmh added the regression It used to work, and now it's broken. label Aug 31, 2019
@nielsmh nielsmh added this to the 1.10.0 milestone Sep 1, 2019
@Eddi-z
Copy link
Contributor

Eddi-z commented Sep 14, 2019

this should be fixed by #7739?

@James103
Copy link
Contributor Author

Might as well call it fixed, according to some testing with fast-forward. Haven't tested with the 50k stations or the Westbourne save yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression It used to work, and now it's broken.
Projects
None yet
Development

No branches or pull requests

4 participants