New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: offscreen gl context panic #24206
Comments
I suspect 1cefae7 |
Is this on Windows? In the HL2 emulator? On device? |
Apparently check_framebuffer_status is causing a GL error to appear: https://github.com/servo/rust-offscreen-rendering-context/blob/317efd913e52228176155280b7d5a29d5591d1f0/src/draw_buffer.rs#L123-L126 |
I'll see if I can reproduce this today. |
More specifically, it's coming from https://github.com/servo/rust-offscreen-rendering-context/blob/317efd913e52228176155280b7d5a29d5591d1f0/src/draw_buffer.rs#L247-L250 and I'm not yet sure why. |
Update sparkle for GLES fix. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24206 - [x] These changes do not require tests because no GLES tests on CI. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24212) <!-- Reviewable:end -->
While running: https://www.joshmatthews.net/webgl-to-webxr/webxr-ar.html
The text was updated successfully, but these errors were encountered: