Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sparkle for GLES fix. #24212

Merged
merged 1 commit into from Sep 14, 2019
Merged

Update sparkle for GLES fix. #24212

merged 1 commit into from Sep 14, 2019

Conversation

jdm
Copy link
Member

@jdm jdm commented Sep 13, 2019


This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 13, 2019
@jdm
Copy link
Member Author

jdm commented Sep 13, 2019

r? @asajeffrey

@highfive highfive assigned asajeffrey and unassigned nox Sep 13, 2019
@asajeffrey
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 8f7fa5b has been approved by asajeffrey

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 13, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit 8f7fa5b with merge a43e25c...

bors-servo pushed a commit that referenced this pull request Sep 13, 2019
Update sparkle for GLES fix.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24206
- [x] These changes do not require tests because no GLES tests on CI.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24212)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 13, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit 8f7fa5b with merge 91d2bd3...

bors-servo pushed a commit that referenced this pull request Sep 13, 2019
Update sparkle for GLES fix.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24206
- [x] These changes do not require tests because no GLES tests on CI.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24212)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 13, 2019
@bors-servo
Copy link
Contributor

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: asajeffrey
Pushing 91d2bd3 to master...

@bors-servo bors-servo merged commit 8f7fa5b into servo:master Sep 14, 2019
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regression: offscreen gl context panic
5 participants