Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: m-labs/nmigen
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1c091e67a422
Choose a base ref
...
head repository: m-labs/nmigen
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b92e967b7815
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Sep 12, 2019

  1. lib.fifo: make fwft a keyword-only argument.

    Because it accepts a boolean.
    whitequark committed Sep 12, 2019
    Copy the full SHA
    b92e967 View commit details
Showing with 4 additions and 4 deletions.
  1. +3 −3 nmigen/lib/fifo.py
  2. +1 −1 nmigen/test/test_lib_fifo.py
6 changes: 3 additions & 3 deletions nmigen/lib/fifo.py
Original file line number Diff line number Diff line change
@@ -58,7 +58,7 @@ class FIFOInterface:
w_attributes="",
r_attributes="")

def __init__(self, width, depth, fwft):
def __init__(self, width, depth, *, fwft):
self.width = width
self.depth = depth
self.fwft = fwft
@@ -121,8 +121,8 @@ class SyncFIFO(Elaboratable, FIFOInterface):
""".strip(),
w_attributes="")

def __init__(self, width, depth, fwft=True):
super().__init__(width, depth, fwft)
def __init__(self, width, depth, *, fwft=True):
super().__init__(width, depth, fwft=fwft)

self.level = Signal.range(depth + 1)

2 changes: 1 addition & 1 deletion nmigen/test/test_lib_fifo.py
Original file line number Diff line number Diff line change
@@ -46,7 +46,7 @@ class FIFOModel(Elaboratable, FIFOInterface):
Non-synthesizable first-in first-out queue, implemented naively as a chain of registers.
"""
def __init__(self, width, depth, fwft, rdomain, wdomain):
super().__init__(width, depth, fwft)
super().__init__(width, depth, fwft=fwft)

self.rdomain = rdomain
self.wdomain = wdomain