New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DOMStringList #24208
Labels
A-content/dom
Interacting with the DOM from web content
C-assigned
There is someone working on resolving the issue
Comments
If the spec calls for it for your work, I agree. |
@highfive: assign me |
Hey @rasviitanen! Thanks for your interest in working on this issue. It's now assigned to you! |
4 tasks
bors-servo
pushed a commit
that referenced
this issue
Sep 17, 2019
add webidl bindings for DOMStringList <!-- Please describe your changes on the following line: --> To prepare for the implementation of `IndexedDB` a DOM interface for `DOMStringList` is added. This change: * Adds a new IDL file for `DOMStringList` * Lists `domstringlist.rs` in `mod.rs` * Defines a new DOMStruct `DOMStringList` * Changes some test expectations related to `DOMStringList` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #24208 - [X] These changes do not require tests because: We are not yet able to fully test the functions of `DOMStringList` in the WPT, because it is not possible to create an object of the type `DOMStringList` until e.g. `indexeddb` or `location.ancestorOrigins` is implemented. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24220) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this issue
Sep 18, 2019
add webidl bindings for DOMStringList <!-- Please describe your changes on the following line: --> To prepare for the implementation of `IndexedDB` a DOM interface for `DOMStringList` is added. This change: * Adds a new IDL file for `DOMStringList` * Lists `domstringlist.rs` in `mod.rs` * Defines a new DOMStruct `DOMStringList` * Changes some test expectations related to `DOMStringList` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #24208 - [X] These changes do not require tests because: We are not yet able to fully test the functions of `DOMStringList` in the WPT, because it is not possible to create an object of the type `DOMStringList` until e.g. `indexeddb` or `location.ancestorOrigins` is implemented. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24220) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-content/dom
Interacting with the DOM from web content
C-assigned
There is someone working on resolving the issue
I think we should implement
DOMStringList
.Spec: https://html.spec.whatwg.org/multipage/common-dom-interfaces.html#domstringlist
Blocks: #6963
The following warning is listed in the spec. Someone else might have more information on this.
Notes on block:
DOMStringList is needed in order to implement
IndexedDB
according to the specification (both the new 3.0 draft and the W3C recommendation document).https://www.w3.org/TR/IndexedDB-2/
https://w3c.github.io/IndexedDB/
Used in e.g. the
IDBDataBase
for the object store names. It is also used inIDBObjectStore
andIDBTransaction
The text was updated successfully, but these errors were encountered: