Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wireguard-tools: 0.0.20191012 -> 0.0.20191127 #74347

Merged
merged 1 commit into from Nov 27, 2019

Conversation

d-xo
Copy link
Contributor

@d-xo d-xo commented Nov 27, 2019

Motivation for this change

new snapshot: https://lists.zx2c4.com/pipermail/wireguard/2019-November/004658.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @elseym @ericsagnes @Mic92 @zx2c4 @globin @Ma27

@zx2c4
Copy link
Contributor

zx2c4 commented Nov 27, 2019

👍

@Ma27
Copy link
Member

Ma27 commented Nov 27, 2019

@ofborg test wireguard wireguard-generated wireguard-namespaces

@d-xo
Copy link
Contributor Author

d-xo commented Nov 27, 2019

nix-review pr 74347 fails with the following output:

$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/74347/head:refs/nix-review/1
remote: Enumerating objects: 95, done.
remote: Counting objects: 100% (95/95), done.
remote: Compressing objects: 100% (54/54), done.
remote: Total 106 (delta 64), reused 42 (delta 40), pack-reused 11
Receiving objects: 100% (106/106), 254.21 KiB | 1.16 MiB/s, done.
Resolving deltas: 100% (65/65), completed with 26 local objects.
From https://github.com/NixOS/nixpkgs
   222932255ef..35b35ac269a  master     -> refs/nix-review/0
$ git worktree add /home/me/.cache/nix-review/pr-74347-1/nixpkgs 35b35ac269a4b4b31bcb1901e21b432b60dfb189
Preparing worktree (detached HEAD 35b35ac269a)
Updating files: 100% (20397/20397), done.
HEAD is now at 35b35ac269a Merge pull request #74097 from r-ryantm/auto-update/ace
$ git merge --no-commit bdcc0f420c4b890a3c5199b54ecbe94319b713f8
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --max-jobs 8 --option build-use-sandbox true -f /home/me/.cache/nix-review/pr-74347-1/build.nix
warning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
builder for '/nix/store/05ylcvw8i9a11w68gyz580575b9snm1f-linux-5.4-libre-src.drv' failed with exit code 127; last 9 log lines:
  unpacking sources
  unpacking source archive /nix/store/476gpxsc3h1v6qhfxf706n85llc6l5km-linux-5.4.tar.xz
  source root is linux-5.4
  setting SOURCE_DATE_EPOCH to timestamp 1574641921 of file linux-5.4/virt/lib/irqbypass.c
  patching sources
  configuring
  no configure script, doing nothing
  building
  /nix/store/whpnlfj79vd8p175rp1bwg0x7wz5lmj1-stdenv-linux/setup: line 1300: /nix/store/0jf6kilyw5fz8bwxfn15dnmm3vwsn10l-branches-r16794/5.4/deblob-5.4: No such file or directory
cannot build derivation '/nix/store/p9rb0mi6zw0l2rfmg1ssr116k4h9rs8s-linux-config-5.4.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/1sax0dd1x0rxxv23d0jh2iwzrhbv8l2f-linux-5.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/lr5lnbmiic3nn6drr4dvqck3fdm2fgaz-wireguard-0.0.20191127.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/blv0c0qbs2ibzr0lhfpwypd2n9z5ql96-env.drv': 1 dependencies couldn't be built
[0 built (1 failed)]
error: build of '/nix/store/blv0c0qbs2ibzr0lhfpwypd2n9z5ql96-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/74347
2 package are marked as broken and were skipped:
linuxPackages_hardkernel_4_14.wireguard linuxPackages_hardkernel_latest.wireguard

1 package failed to build:
linuxPackages_latest-libre.wireguard

14 package were built:
linuxPackages-libre.wireguard linuxPackages.wireguard linuxPackages_4_14.wireguard linuxPackages_4_4.wireguard linuxPackages_4_9.wireguard linuxPackages_5_3.wireguard linuxPackages_5_4.wireguard linuxPackages_hardened.wireguard linuxPackages_latest_hardened.wireguard linuxPackages_latest_xen_dom0.wireguard linuxPackages_testing_bcachefs.wireguard linuxPackages_testing_hardened.wireguard linuxPackages_xen_dom0.wireguard wireguard-tools

[0.0 MiB DL]
error: build log of '/nix/store/lr5lnbmiic3nn6drr4dvqck3fdm2fgaz-wireguard-0.0.20191127.drv' is not available

Is this error related to the wireguard version bump?

@Ma27
Copy link
Member

Ma27 commented Nov 27, 2019

cannot build derivation '/nix/store/p9rb0mi6zw0l2rfmg1ssr116k4h9rs8s-linux-config-5.4.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/1sax0dd1x0rxxv23d0jh2iwzrhbv8l2f-linux-5.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/lr5lnbmiic3nn6drr4dvqck3fdm2fgaz-wireguard-0.0.20191127.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/blv0c0qbs2ibzr0lhfpwypd2n9z5ql96-env.drv': 1 dependencies couldn't be built

Linux 5.4 is currently failing, so this doesn't seem related.

@Ma27 Ma27 merged commit ec3ac88 into NixOS:master Nov 27, 2019
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 27, 2019
@Ma27
Copy link
Member

Ma27 commented Nov 27, 2019

Thanks! Backported as 1343f33.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 27, 2019
@d-xo d-xo deleted the wireguard-20191127 branch November 27, 2019 17:46
@iclanzan
Copy link
Contributor

The wg-quick service is not starting anymore because of this PR. iptables is a new dependency and it was not added to PATH.

@iclanzan iclanzan mentioned this pull request Nov 27, 2019
10 tasks
@d-xo d-xo mentioned this pull request Nov 28, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants