Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.sphinxcontrib-katex: init at 0.5.1 #74345

Merged
merged 1 commit into from Mar 14, 2020
Merged

pythonPackages.sphinxcontrib-katex: init at 0.5.1 #74345

merged 1 commit into from Mar 14, 2020

Conversation

jluttine
Copy link
Member

Motivation for this change

Add Sphinx extension for KaTeX.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jluttine jluttine force-pushed the init-sphinxcontrib-katex-0.5.1 branch from 8ccc09f to c9eebe7 Compare November 27, 2019 19:48
@jluttine
Copy link
Member Author

jluttine commented Mar 9, 2020

@jonringer Is this now approved?

@jluttine jluttine force-pushed the init-sphinxcontrib-katex-0.5.1 branch from c9eebe7 to 29edca6 Compare March 11, 2020 08:17
@jluttine
Copy link
Member Author

@jonringer Thanks for the review! I made the fixes you suggested.

jonringer
jonringer approved these changes Mar 14, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74345
2 package built:
python37Packages.sphinxcontrib-katex python38Packages.sphinxcontrib-katex

@jonringer jonringer merged commit 24219f6 into NixOS:master Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jluttine @jonringer