Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libterm-neovim: 2019-08-28 -> 2019-10-08 #74365

Merged
merged 1 commit into from Nov 27, 2019
Merged

libterm-neovim: 2019-08-28 -> 2019-10-08 #74365

merged 1 commit into from Nov 27, 2019

Conversation

iclanzan
Copy link
Contributor

Motivation for this change

Updating libterm to the same version that neovim ships with fixes #74286.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rvolosatovs

@iclanzan
libterm-neovim: 2019-08-28 -> 2019-10-08
4040b6e 
Updating to the same version as neovim ships with fixes
NixOS#74286.
@adisbladis
Copy link
Member

Can confirm that the emacs binding still works with this PR.

@adisbladis
Copy link
Member

And while I'm not a vim user I just tested neovim too, works just fine.

@adisbladis adisbladis merged commit 328f811 into NixOS:master Nov 27, 2019
@iclanzan iclanzan mentioned this pull request Nov 27, 2019
Closed
@iclanzan iclanzan deleted the fix-neovim-crash branch November 27, 2019 20:56
@iclanzan iclanzan restored the fix-neovim-crash branch November 28, 2019 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis adisbladis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Neovim Segmentation Fault
2 participants
@iclanzan @adisbladis