-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding config option to immediately edit dimensions #514
Adding config option to immediately edit dimensions #514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK other than the comment.
src/confscreen.cpp
Outdated
@@ -342,6 +347,9 @@ void TextWindow::ShowConfiguration() { | |||
SS.automaticLineConstraints ? CHECK_TRUE : CHECK_FALSE); | |||
Printf(false, " %Fd%f%Ll%s use turntable mouse navigation%E", &ScreenChangeTurntableNav, | |||
SS.turntableNav ? CHECK_TRUE : CHECK_FALSE); | |||
Printf(false, " %Fd%f%Ll%s immediately edit dimensions%E", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about edit newly added dimensions
? The variable naming is fine, but the preference is a bit confusing.
The existing behavior should not change for people who are already using SolveSpace. |
Changed the default to false and used your suggested label. Will take a bit... |
I can just squash while merging in a simple case like this, GitHub has a button for it. |
Cool! then I leave it =)
Which seemed to work allright =) |
Usually people use |
Indeed, I am not very familiar with git I notices since I mostly only commit and push things with it, should read the manual again... |
976239c
to
3728ee9
Compare
Force pushed it anyway ;) |
This needs a changelog addition as well. |
Here it is again, this time with config option.
Let me know if the default should be on or off, and if the variables / place in the preferences pane are fine with you.
The option does now also work on the angle constraint.