Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ipympl: init at 0.3.3 #74344

Merged
merged 1 commit into from Mar 10, 2020
Merged

pythonPackages.ipympl: init at 0.3.3 #74344

merged 1 commit into from Mar 10, 2020

Conversation

jluttine
Copy link
Member

Motivation for this change

Add Python package ipympl.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jluttine
Copy link
Member Author

jluttine commented Mar 9, 2020

@jonringer If you approve this now, could you mark this as approved?

jonringer
jonringer approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
has tests 👍

https://github.com/NixOS/nixpkgs/pull/74344
3 package built:
python27Packages.ipympl python37Packages.ipympl python38Packages.ipympl

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.ipympl python37Packages.ipympl python38Packages.ipympl

@jonringer jonringer merged commit e1f484f into NixOS:master Mar 10, 2020
@FRidh
Copy link
Member

FRidh commented Mar 10, 2020

ohh that is one very interesting extension!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jluttine @jonringer @FRidh