Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
opencv2 is essentially EOL and has security concerns
OpenCV is used for image denoising in
yafaray-core
Tested this by rendering the extremely convenient, denoising-enabled test scene provided in the yafaray source https://github.com/YafaRay/Core/tree/master/tests/test01 , which incidentally would probably be fairly easy to turn into an
installCheck
in case anyone wanted to have a go - the only tricky thing would be to allow a tolerance of difference against the reference image, due to e.g. image noise.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @Hodapp87