fplll: 5.2.1 -> 5.3.0, python.pkgs.fpylll: 0.4.1dev -> 0.5.0dev #74372
Conversation
|
@timokau probably has a qualified opinion |
|
I don't have any opinion other than |
|
Ah right, I guess you only start forming opinion once Sage is the only thing that fails. |
|
Well that's included in nix-review passing ;) What I meant is that I don't personally use this package, so I don't really have anything to add in addition to "it shouldn't obviously break anything". |
|
Well, you might have already heard of some complaints about the new version breaking Sage. (And no other use of this package seems to be known) |
|
Good point :) There don't seem to be any known issues. Other than that, I usually trust the testsuite. It tends to have lots of false-positives, but rarely false-negatives. |
|
Fpyll update is not trivial, something has changed with the test setup. I've bisected it to either 327c4c1a3f86c0fc877cfe3e177a3ab3664ece5b or 9732fdb40cf1bd43ad1f60762ec0a8401743fc79. No time to continue right now. I'll try to get back to it when I have time, but if someone else wants to finish I certainly don't mind ;) |
timokau
force-pushed
the
auto-update/fplll
branch
from
72172b0
to
8e4765f
Compare
|
Okay the fpylll build succeeds now. There is one transient test issue (fplll/fpylll#161) that I've skipped for now. We should give upstream a couple of days to react to that before merging. I haven't run |
timokau
changed the title
|
|
timokau
force-pushed
the
auto-update/fplll
branch
from
8e4765f
to
455daf0
Compare
|
Should be good to go now if @7c6f434c approves of the cleanup commits. If you still prefer the more concise style you used when you created the package, I can revert that change. I just thought that commits like the "clean up dependencies" one have a nicer diff with the new formatting. The changelog is not ideal, since it links to a search. The project also has a proper changelog, but that has been out of date for a couple of years. |
timokau
force-pushed
the
auto-update/fplll
branch
from
455daf0
to
fe9a7cd
Compare
According to my perception of the current community standards.
autoreconfHook implies autotools.
timokau
force-pushed
the
auto-update/fplll
branch
from
fe9a7cd
to
3d9d462
Compare
|
The failing test is now resolved as well. |
|
As I consider you more competent than myself here (because of your great Sage work), I don't have any opinions re: style. Re: changelog — the pain, it's not just search, it is JavaScript-only search… I propose https://github.com/fplll/fplll/releases as the first entry in the changelog list. (I have read the entire diff and briefly checked the basic reasonability of the added patch) |
The two packages need to be updated together, since fpylll 0.4.1 requires the old fplll version and fpylll 0.5.0 requires the new one.
timokau
force-pushed
the
auto-update/fplll
branch
from
3d9d462
to
0dcd09b
Compare
Appreciate the compliment :)
Oh neat, I didn't realise the git tags had release notes as well. I've added that to the list (although they don't seem complete -- for example the latest version doesn't have any release notes there).
Please have another look (just changed the changelogs) and merge if it looks good to you. |
|
I wonder at what point we will just subscribe a bot to various mailing list with release announcements because it is more reliable… |
|
Unfortunately this PR broke the aarch64 build of fpylll: fplll/fpylll#162 Though the test failures look pretty harmless, so we could probably just ignore them. |
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/fplll/versions.
meta.description for fplll is: '"Lattice algorithms using floating-point arithmetic"'.
meta.homepage for fplll is: '""
Compare changes on GitHub
Checks done (click to expand)
built on NixOS
The tests defined in
passthru.tests, if any, passed0 of 0 passed binary check by having a zero exit code.
0 of 0 passed binary check by having the new version present in output.
found 5.3.0 with grep in /nix/store/00q56pdlsnpyj8mwjwf0xd2qzwl5ixwr-fplll-5.3.0
directory tree listing: https://gist.github.com/215205c63fcbc398cd1723a6bdbb13b0
du listing: https://gist.github.com/1f63c8aa27eba9e5b3234feeb4dfcb58
Rebuild report (if merged into master) (click to expand)
18 total rebuild path(s)
6 package rebuild(s)
6 x86_64-linux rebuild(s)
4 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
fplll
python27Packages.fpylll
python37Packages.fpylll
python38Packages.fpylll
sage
sageWithDoc
Instructions to test this update (click to expand)
Either download from Cachix:
(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
cc @7c6f434c for testing.