Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lego: 3.0.2 -> 3.2.0 #74371

Merged
merged 1 commit into from Dec 5, 2019
Merged

lego: 3.0.2 -> 3.2.0 #74371

merged 1 commit into from Dec 5, 2019

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Nov 27, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/z9j7v4f265153ark4hvgiq88sgxb33p8-lego-3.0.2 75075032
/nix/store/m0vy2ysbs0vgifwdq4sxza1ab5xm57qs-lego-3.2.0 76082072

Notify maintainers

cc @andrew-d

supersede #72952

@ofborg ofborg bot requested review from andrew-d and kalbasit November 27, 2019 21:50
andrew-d
andrew-d suggested changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@andrew-d andrew-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works locally, but it looks like there's some internal-only packages getting built and dropped into the bin subdirectory. Could you add the following line?

  subPackages = [ "cmd/lego" ];

Confirmed that everything builds and runs successfully with that ☝️ addition.

@bbigras
Copy link
Contributor Author

bbigras commented Nov 28, 2019

Could you add the following line?
subPackages = [ "cmd/lego" ];

Done. Thanks!

@ofborg ofborg bot requested a review from andrew-d November 28, 2019 05:37
andrew-d
andrew-d approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@andrew-d andrew-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bbigras
Copy link
Contributor Author

bbigras commented Dec 3, 2019

ping @kalbasit

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/77

@timokau
Copy link
Member

timokau commented Dec 5, 2019

Thanks!

@timokau timokau merged commit cc6cf0a into NixOS:master Dec 5, 2019
@timokau timokau mentioned this pull request Dec 5, 2019
Closed
10 tasks
@bbigras bbigras deleted the lego branch December 5, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-d andrew-d andrew-d approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bbigras @nixos-discourse @timokau @andrew-d