Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

purescript: 0.13.4 -> 0.13.5 #74300

Merged
merged 1 commit into from Nov 27, 2019
Merged

purescript: 0.13.4 -> 0.13.5 #74300

merged 1 commit into from Nov 27, 2019

Conversation

mbbx6spp
Copy link
Contributor

@mbbx6spp mbbx6spp commented Nov 27, 2019 •
edited

Motivation for this change

A new PureScript compiler version has been released (v0.13.5).

macOS:

$ nix-prefetch-url https://github.com/purescript/purescript/releases/download/v0.13.5/macos.tar.gz                    
[5.8 MiB DL]
path is '/nix/store/vfsbcg2jim2iwsj61cjf545ivpks7p6z-macos.tar.gz'
19bb50m0cd738r353blgy21d842b3yj58xfbplk7bz59jawj9lym

Linux:

$ nix-prefetch-url https://github.com/purescript/purescript/releases/download/v0.13.5/linux64.tar.gz                  
[9.9 MiB DL]
path is '/nix/store/3cl0468mg9l9r7vmpha0fa0mv2h5gv2q-linux64.tar.gz'
016wvwypgb4859f0n1lqsqv9a8cca2y8g7d6ffvzx6rncd115gxi
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mbbx6spp
Copy link
Contributor Author

Tested on both NixOS (nixos-version: 19.09.1292.e1843646b04 (Loris)) and macOS (Darwin Kernel Version 18.7.0).

@ofborg ofborg bot requested a review from justinwoo November 27, 2019 01:30
jonringer
jonringer approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable shows usage

[3 built, 2 copied (1.0 MiB), 0.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74300
1 package were built:
purescript

@jonringer
Copy link
Contributor

@GrahamcOfBorg build purescript

@jonringer jonringer merged commit a1f82db into NixOS:master Nov 27, 2019
@mbbx6spp mbbx6spp deleted the purescript-0.13.5 branch December 2, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@justinwoo justinwoo Awaiting requested review from justinwoo

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mbbx6spp @jonringer