Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnirehtet: 2.3 -> 2.4 #74377

Merged
merged 1 commit into from Nov 30, 2019
Merged

gnirehtet: 2.3 -> 2.4 #74377

merged 1 commit into from Nov 30, 2019

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Nov 27, 2019

Motivation for this change

https://github.com/Genymobile/gnirehtet/releases/tag/v2.4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @symphorien

@ofborg ofborg bot requested a review from symphorien November 27, 2019 22:30
symphorien
symphorien approved these changes Nov 30, 2019
View reviewed changes
Copy link
Member

@symphorien symphorien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it seems to work. Thanks.

@dywedir dywedir merged commit 8be1f98 into NixOS:master Nov 30, 2019
@dywedir dywedir deleted the gnirehtet branch November 30, 2019 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dywedir @symphorien