New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mpdris2: use python3 for #74295 #74373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From looking at the imports you need glib
and libnotify
in buildInputs
.
Please also port to using python3Packages.buildPythonApplication
, where you'll need to set format = "other";
to use the make build.
Then add gobject-introspection
and wrapGAppsHook
to nativeBuildInputs
.
Note you can also drop wrapPython
as buildPythonApplication
automatically includes a variety of hooks.
a86c9c5
to
c185198
Compare
The only thing that doesn't seem to work is notifications. No matter where I placed I'm not a Python programmer so if there are any more Python-specific changes that need to be made I'd appreciate patches. Thank you. |
@pjones That's because this uses the libnotify library and glib through gobject-introspection. |
Oh, forgot to mention the gobject-introspection setup hook doesn't work with stictDeps which is default in buildPython. You need to set |
And add a comment linking to #56943 next to that. |
c185198
to
488b4a6
Compare
Latest commit includes all recommended changes. However notifications don't seem to be working. |
The notifications work for me. I created
Then ran The already running What desktop environment are you using. Do you have notification server running? |
d59e9d2
to
9ac55c6
Compare
@pjones I've pushed the requested changes. Could you try again now? |
@worldofpeace I tried commit 9ac55c6a743cdddf8768b04b8b58b75a23abd7f3 and everything works except notifications. I'm running KDE and have no problems with notifications in general. I recently stopped using mpdris2. I'm going to push a commit that removes me from the maintainers list. |
Also use fetchFromGitHub for hash stability. Co-authored-by: worldofpeace <worldofpeace@protonmail.ch>
9ac55c6
to
db091af
Compare
Strange, I believe @jtojnar and I both tested under Gnome3. So perhaps it's related to this, or something is missing from the wrapper that just happen to be in our global environment (or terminal). |
Got it 👍 I believe you've done this in the force push, will merge. |
Motivation for this change
Update to python3 as per #74295
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @worldofpeace