doc/contributing: mention icons & themes folders #74376
Conversation
| @@ -652,6 +662,16 @@ args.stdenv.mkDerivation (args // { | |||
| </variablelist> | |||
| </listitem> | |||
| </varlistentry> | |||
| <varlistentry> | |||
| <term> | |||
| If it’s a <emphasis>desktop theme</emphasis>: | |||
There was a problem hiding this comment.
Desktop theme is ambiguous. Icon themes are also themes; so are sound themes. Maybe GTK and Qt themes, or whatever?
There was a problem hiding this comment.
It's not just GTK and Qt though. It could be E17 themes, a login manager theme, maybe even a Grub or Plymouth one.
|
Second iteration |
| <term> | ||
| If it’s a <emphasis>theme</emphasis> for a <emphasis>desktop environment</emphasis>, | ||
| a <emphasis>window manager</emphasis> or a <emphasis>display manager</emphasis>: |
There was a problem hiding this comment.
I guess this means we won't regroup sound themes here?
Like https://github.com/NixOS/nixpkgs/tree/master/pkgs/data/misc/sound-theme-freedesktop.
There was a problem hiding this comment.
(saw this after)
no my thinking is that sound themes would be under their own arbo, just like icons
|
Asking the above because @jtojnar mentioned sound themes in #74376 (comment). It seems we've gone the ambiguous route to just group anything that could be like a theme to be in that directory. I'm not opposed to this, but I think maybe it would catch sound themes too. |
|
No, in my mind sound themes would be located under a dedicated Let's keep in mind that we want to document what's already done up to now. Our folder structure is already a little lax, but it's still better than everything in misc or
So when a PR will want to add a sound theme to nixpkgs, then we could suggest to the contributor to create a |
|
Sounds about right @c0deaddict 👍 |
|
On a side note: if we'd like to make a clear precedent for sound themes, I'm ready to take some time and craft another PR after this for the relocation of sound-theme-freedesktop under |
Motivation for this change
Follow-up to #74060
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @worldofpeace @romildo