Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chefdk: fix build #74314

Merged
merged 1 commit into from Nov 27, 2019
Merged

chefdk: fix build #74314

merged 1 commit into from Nov 27, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Nov 27, 2019

Motivation for this change

This fixes #70171

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@etu etu mentioned this pull request Nov 27, 2019
Merged
10 tasks
@ofborg ofborg bot requested a review from offlinehacker November 27, 2019 09:51
c0bw3b
c0bw3b approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 74314 1

1 package were build:
  • chefdk

@c0bw3b c0bw3b merged commit bfdd3e1 into NixOS:master Nov 27, 2019
@etu etu deleted the fix-chef-build branch November 27, 2019 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chef-dk is broken and missing some utils
2 participants
@etu @c0bw3b