pybind11: Unify with pythonPackages.pybind11 #74302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knedlsepp
force-pushed
the
unify-pybind
branch
2 times, most recently
from
d63b3a2
to
ad054a3
Compare
ofborg
bot
added
6.topic: python
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
jonringer
suggested changes
Nov 27, 2019
There was a problem hiding this comment.
python packages aren't able to discover it through pip
[4 built (11 failed), 89 copied (1218.4 MiB), 417.4 MiB DL]
error: build of '/nix/store/dsmkqa55zadlzvvssair3k5d9lsahlsf-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/74302
32 package failed to build:
ocrmypdf pybind11 pybitmessage python27Packages.fasttext python27Packages.fipy python27Packages.loo-py python27Packages.pyamg python27Packages.pyfma python27Packages.pyopencl python27Packages.reikna python27Packages.sasmodels python37Packages.accupy python37Packages.fasttext python37Packages.fipy python37Packages.loo-py python37Packages.pikepdf python37Packages.pyamg python37Packages.pyfma python37Packages.pyopencl python37Packages.reikna python37Packages.sasmodels python38Packages.accupy python38Packages.fasttext python38Packages.fipy python38Packages.loo-py python38Packages.pikepdf python38Packages.pyamg python38Packages.pyfma python38Packages.pyopencl python38Packages.reikna python38Packages.sasmodels sasview
2 package were built:
python37Packages.pybind11 python38Packages.pybind11
|
example failure: |
knedlsepp
changed the title
knedlsepp
force-pushed
the
unify-pybind
branch
2 times, most recently
from
a5c0291
to
fd60bbf
Compare
Instead of one derivation providing a cmake-compatible library and one providing a setuptools-compatible library, we now support both ways of consuming the library for both pybind11 and python.pkgs.pybind11.
knedlsepp
force-pushed
the
unify-pybind
branch
from
fd60bbf
to
e2a4d30
Compare
knedlsepp
changed the title
|
@GrahamcOfBorg build python2Packages.pybind11 python37Packages.pybind11 python38Packages.pybind11 python3Packages.accupy python38Packages.pyopencl |
@jonringer Sorry for opening this PR before it was ready. I think it's now in a state where it should do as advertised. Do you mind taking a look again? :) |
jonringer
approved these changes
Nov 29, 2019
There was a problem hiding this comment.
diff LGTM
sasview was broken on master, needs some love. But that can be done outside of this PR
[35 built (1 failed), 566 copied (3337.4 MiB), 887.6 MiB DL]
error: build of '/nix/store/di8k6m09y5hka6waw4fg5d1qf1kqbnsj-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/74302
1 package failed to build:
sasview
33 package were built:
ocrmypdf pybind11 pybitmessage python27Packages.fasttext python27Packages.fipy python27Packages.loo-py python27Packages.pyamg python27Packages.pyfma python27Packages.pyopencl python27Packages.reikna python27Packages.sasmodels python37Packages.accupy python37Packages.fasttext python37Packages.fipy python37Packages.loo-py python37Packages.pikepdf python37Packages.pyamg python37Packages.pybind11 python37Packages.pyfma python37Packages.pyopencl python37Packages.reikna python37Packages.sasmodels python38Packages.accupy python38Packages.fasttext python38Packages.fipy python38Packages.loo-py python38Packages.pikepdf python38Packages.pyamg python38Packages.pybind11 python38Packages.pyfma python38Packages.pyopencl python38Packages.reikna python38Packages.sasmodels
|
Thx. Gave sasview a glance. Looks like the wxPython installation in general is at fault since it's site-packages directory contains a "build" directory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Instead of one derivation providing a cmake-compatible library and one
providing a setuptools compatible library, we now support both ways of
consuming the library for both pybind11 and python.pkgs.pybind11.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @