Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connman-notify: 2014-06-23 -> 2019-10-05 #74321

Merged
merged 1 commit into from Dec 4, 2019
Merged

connman-notify: 2014-06-23 -> 2019-10-05 #74321

merged 1 commit into from Dec 4, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Nov 27, 2019

Motivation for this change
  • Update to the latest revision.
  • Upstream moved to gitlab
  • Moved to python3
  • Uses buildPythonApplication
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace

@romildo romildo mentioned this pull request Nov 27, 2019
Merged
10 tasks
worldofpeace
worldofpeace suggested changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This uses gobject-introspection

So we need to add gobject-introspection to nativeBuildInputs for the setup hook, wrapGAppsHook and lastly glib to buildInputs.

Other things are in the GNOME manual:

worldofpeace
worldofpeace suggested changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.
Please also add strictDeps = false; as the gobject-introspection setup-hook doesn't work with it.
And with a comment to #56943.

pkgs/tools/networking/connman/connman-notify/default.nix Show resolved Hide resolved
pkgs/tools/networking/connman/connman-notify/default.nix Show resolved Hide resolved
worldofpeace
worldofpeace approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks a lot ✨

@worldofpeace worldofpeace merged commit ff954e0 into NixOS:master Dec 4, 2019
@romildo romildo deleted the upd.connman-notify branch December 4, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
Python 2 deprecation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romildo @Br1ght0ne @worldofpeace