Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

egl-wayland: fix build #74325

Merged
merged 1 commit into from Nov 27, 2019
Merged

egl-wayland: fix build #74325

merged 1 commit into from Nov 27, 2019

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Nov 27, 2019

Motivation for this change

Add headers that got moved in #72999.
Also contains patch for a missing include which ist reported upstream: NVIDIA/egl-wayland#24

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @hedning @primeos @adisbladis

@B4dM4n
egl-wayland: fix build
46e98a9 
Add headers that got moved in NixOS#72999
@B4dM4n B4dM4n mentioned this pull request Nov 27, 2019
Merged
10 tasks
@ofborg ofborg bot requested a review from hedning November 27, 2019 12:24
@B4dM4n
Copy link
Contributor Author

B4dM4n commented Nov 27, 2019

I saw #74322 using fetchpatch to include a commit from a PR.
Are such commits persistent? Will they stay even if the PR gets rejected or amended?

I will switch this PR to fetchpatch if they are.

@adisbladis adisbladis merged commit e237d88 into NixOS:master Nov 27, 2019
@adisbladis
Copy link
Member

@B4dM4n I believe PR commits are GCd at some point if overwritten.

@B4dM4n B4dM4n deleted the egl-wayland-fix-build branch November 27, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@B4dM4n @adisbladis