New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Set Permission
API to testdriver.js
#20461
Add Set Permission
API to testdriver.js
#20461
Conversation
descriptor = permission_params["descriptor"] | ||
name = descriptor["name"] | ||
state = permission_params["state"] | ||
one_realm = permission_params["oneRealm"] if "oneRealm" in permission_params else False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one_realm = permission_params["oneRealm"] if "oneRealm" in permission_params else False | |
one_realm = permission_params.get("oneRealm", False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should work, not tested...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @foolip
descriptor = permission_params["descriptor"] | ||
name = descriptor["name"] | ||
state = permission_params["state"] | ||
one_realm = permission_params["oneRealm"] if "oneRealm" in permission_params else False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
4f128c2
to
69a3293
Compare
Rebased and addressed comments. Only remaining failures are stability checks timing out, as expected. @foolip ping? |
Looks like there were 403 affected tests, which is consistent with Taskcluster stability check timeouts. I'll admin merge. |
Since #20461 and #5671 were fixed, it now becomes possible to automate some Web Platform Tests, and have them run on all browsers automatically. Clipboard API tests previously were duplicated in non-WPT in order to automate them via PermissionsHelper and detect regressions. This allows us to shed a lot of duplicate tests, as well as a difficult-to-remember process of remembering to update both test suites when changes were made. Bug: 1076691 Change-Id: Ibdfdf37e75da68d7a4b1e2ba986e4198b73230ac
Since #20461 and #5671 were fixed, it now becomes possible to automate some Web Platform Tests, and have them run on all browsers automatically. Clipboard API tests previously were duplicated in non-WPT in order to automate them via PermissionsHelper and detect regressions. This allows us to shed a lot of duplicate tests, as well as a difficult-to-remember process of remembering to update both test suites when changes were made. Bug: 1076691 Change-Id: Ibdfdf37e75da68d7a4b1e2ba986e4198b73230ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065346 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#764967}
Since web-platform-tests/wpt#20461 and web-platform-tests/wpt#5671 were fixed, it now becomes possible to automate some Web Platform Tests, and have them run on all browsers automatically. Clipboard API tests previously were duplicated in non-WPT in order to automate them via PermissionsHelper and detect regressions. This allows us to shed a lot of duplicate tests, as well as a difficult-to-remember process of remembering to update both test suites when changes were made. Bug: 1076691 Change-Id: Ibdfdf37e75da68d7a4b1e2ba986e4198b73230ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065346 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#764967}
Since #20461 and #5671 were fixed, it now becomes possible to automate some Web Platform Tests, and have them run on all browsers automatically. Clipboard API tests previously were duplicated in non-WPT in order to automate them via PermissionsHelper and detect regressions. This allows us to shed a lot of duplicate tests, as well as a difficult-to-remember process of remembering to update both test suites when changes were made. Bug: 1076691 Change-Id: Ibdfdf37e75da68d7a4b1e2ba986e4198b73230ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065346 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#764967}
Since #20461 and #5671 were fixed, it now becomes possible to automate some Web Platform Tests, and have them run on all browsers automatically. Clipboard API permission tests were previously outside WPT in order to automate permissions using PermissionsHelper and detect regressions. This allows us to share our permissions tests with other browsers testing using WPT. Bug: 1076691 Change-Id: I1ff6a8bbdf60b8d77fd8621efce840739fbeec23
Since #20461 and #5671 were fixed, it now becomes possible to automate some Web Platform Tests, and have them run on all browsers automatically. Clipboard API permission tests were previously outside WPT in order to automate permissions using PermissionsHelper and detect regressions. This allows us to share our permissions tests with other browsers testing using WPT. Bug: 1076691 Change-Id: I1ff6a8bbdf60b8d77fd8621efce840739fbeec23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200278 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#769171}
Since web-platform-tests/wpt#20461 and web-platform-tests/wpt#5671 were fixed, it now becomes possible to automate some Web Platform Tests, and have them run on all browsers automatically. Clipboard API permission tests were previously outside WPT in order to automate permissions using PermissionsHelper and detect regressions. This allows us to share our permissions tests with other browsers testing using WPT. Bug: 1076691 Change-Id: I1ff6a8bbdf60b8d77fd8621efce840739fbeec23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200278 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#769171}
Since #20461 and #5671 were fixed, it now becomes possible to automate some Web Platform Tests, and have them run on all browsers automatically. Clipboard API permission tests were previously outside WPT in order to automate permissions using PermissionsHelper and detect regressions. This allows us to share our permissions tests with other browsers testing using WPT. Bug: 1076691 Change-Id: I1ff6a8bbdf60b8d77fd8621efce840739fbeec23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200278 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#769171}
…rm Tests, a=testonly Automatic update from web-platform-tests Clipboard API Tests: Automate Web Platform Tests Since web-platform-tests/wpt#20461 and web-platform-tests/wpt#5671 were fixed, it now becomes possible to automate some Web Platform Tests, and have them run on all browsers automatically. Clipboard API tests previously were duplicated in non-WPT in order to automate them via PermissionsHelper and detect regressions. This allows us to shed a lot of duplicate tests, as well as a difficult-to-remember process of remembering to update both test suites when changes were made. Bug: 1076691 Change-Id: Ibdfdf37e75da68d7a4b1e2ba986e4198b73230ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065346 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#764967} -- wpt-commits: 957c333350503196cc1bf72cc9f6d8b4fdfc2b2c wpt-pr: 23332
…sts to WPT., a=testonly Automatic update from web-platform-tests Clipboard API Tests: Move permissions tests to WPT. Since web-platform-tests/wpt#20461 and web-platform-tests/wpt#5671 were fixed, it now becomes possible to automate some Web Platform Tests, and have them run on all browsers automatically. Clipboard API permission tests were previously outside WPT in order to automate permissions using PermissionsHelper and detect regressions. This allows us to share our permissions tests with other browsers testing using WPT. Bug: 1076691 Change-Id: I1ff6a8bbdf60b8d77fd8621efce840739fbeec23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200278 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#769171} -- wpt-commits: 290d03696f5008625c2ebd1bfaf37eb9bff5bd79 wpt-pr: 23617
…rm Tests, a=testonly Automatic update from web-platform-tests Clipboard API Tests: Automate Web Platform Tests Since web-platform-tests/wpt#20461 and web-platform-tests/wpt#5671 were fixed, it now becomes possible to automate some Web Platform Tests, and have them run on all browsers automatically. Clipboard API tests previously were duplicated in non-WPT in order to automate them via PermissionsHelper and detect regressions. This allows us to shed a lot of duplicate tests, as well as a difficult-to-remember process of remembering to update both test suites when changes were made. Bug: 1076691 Change-Id: Ibdfdf37e75da68d7a4b1e2ba986e4198b73230ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065346 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#764967} -- wpt-commits: 957c333350503196cc1bf72cc9f6d8b4fdfc2b2c wpt-pr: 23332
…sts to WPT., a=testonly Automatic update from web-platform-tests Clipboard API Tests: Move permissions tests to WPT. Since web-platform-tests/wpt#20461 and web-platform-tests/wpt#5671 were fixed, it now becomes possible to automate some Web Platform Tests, and have them run on all browsers automatically. Clipboard API permission tests were previously outside WPT in order to automate permissions using PermissionsHelper and detect regressions. This allows us to share our permissions tests with other browsers testing using WPT. Bug: 1076691 Change-Id: I1ff6a8bbdf60b8d77fd8621efce840739fbeec23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200278 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#769171} -- wpt-commits: 290d03696f5008625c2ebd1bfaf37eb9bff5bd79 wpt-pr: 23617
Since web-platform-tests/wpt#20461 and web-platform-tests/wpt#5671 were fixed, it now becomes possible to automate some Web Platform Tests, and have them run on all browsers automatically. Clipboard API permission tests were previously outside WPT in order to automate permissions using PermissionsHelper and detect regressions. This allows us to share our permissions tests with other browsers testing using WPT. Bug: 1076691 Change-Id: I1ff6a8bbdf60b8d77fd8621efce840739fbeec23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200278 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#769171} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 1a94bbf1dd8464157d2c58a62d1a4ed1fdb03cfb
Since web-platform-tests/wpt#20461 and web-platform-tests/wpt#5671 were fixed, it now becomes possible to automate some Web Platform Tests, and have them run on all browsers automatically. Clipboard API tests previously were duplicated in non-WPT in order to automate them via PermissionsHelper and detect regressions. This allows us to shed a lot of duplicate tests, as well as a difficult-to-remember process of remembering to update both test suites when changes were made. Bug: 1076691 Change-Id: Ibdfdf37e75da68d7a4b1e2ba986e4198b73230ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065346 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#764967} Former-commit-id: 59c99fcd658a705942a2b869cbc796c9bf4f621b
Since web-platform-tests/wpt#20461 and web-platform-tests/wpt#5671 were fixed, it now becomes possible to automate some Web Platform Tests, and have them run on all browsers automatically. Clipboard API permission tests were previously outside WPT in order to automate permissions using PermissionsHelper and detect regressions. This allows us to share our permissions tests with other browsers testing using WPT. Bug: 1076691 Change-Id: I1ff6a8bbdf60b8d77fd8621efce840739fbeec23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200278 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#769171} Former-commit-id: 1a94bbf1dd8464157d2c58a62d1a4ed1fdb03cfb
This should address issue #5671