Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds boxes package.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @
Comments
This is my first derivation, hope everything is fine. I have some doubts about the issue with the system wide config file used in boxes. The file is defined in the
Makefile
and defaults to/usr/share/boxes
. In the derivation I'm changing it for$out/boxes-config
. Individual users can define its own config file but, anyway, I'm not sure if there is a better way to go. Also, it would be nice to set the new config file path in amkDerivation
attribute, so that it can be overriden easily if needed. However, if I'm not wrong, I have no way to access$out
from there, so it's not possible.