Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wireguard-tools: fix dependencies #74390

Merged
merged 1 commit into from Nov 28, 2019
Merged

wireguard-tools: fix dependencies #74390

merged 1 commit into from Nov 28, 2019

Conversation

iclanzan
Copy link
Contributor

Motivation for this change

In #74347 wireguard was updated, but not its dependencies. Specifically the notes point to a new dependency on ipdatables without which wg-quick fails to start.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @elseym @ericsagnes @Mic92 @zx2c4 @globin @Ma27

@iclanzan iclanzan changed the title Add iptables to wireguard-tools wireguard-tools: fix dependencies Nov 27, 2019
@ofborg ofborg bot requested review from Ma27, globin, Mic92 and elseym November 28, 2019 00:21
@d-xo
Copy link
Contributor

d-xo commented Nov 28, 2019

Apologies for missing this 🙇‍♀️. I have tested this fix locally and it works.

I have written a test for the wg-quick service (d-xo@162be60) that should catch such regressions in the future, and will submit it as a PR once this fix is merged.

@Mic92 Mic92 merged commit b82d4ed into NixOS:master Nov 28, 2019
@d-xo
Copy link
Contributor

d-xo commented Nov 28, 2019

@Mic92 I think this also needs to go to stable to match #74347.

@Mic92
Copy link
Member

Mic92 commented Nov 28, 2019

9d21383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Awaiting requested review from Ma27

@globin globin Awaiting requested review from globin

@Mic92 Mic92 Awaiting requested review from Mic92

@elseym elseym Awaiting requested review from elseym

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iclanzan @d-xo @Mic92