Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: 1.2.0 -> 1.2.1 #74391

Merged
merged 1 commit into from Nov 28, 2019
Merged

bazel: 1.2.0 -> 1.2.1 #74391

merged 1 commit into from Nov 28, 2019

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Nov 27, 2019 •
edited

Motivation for this change

https://github.com/bazelbuild/bazel/releases/tag/1.2.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @flokli @Profpatsch @guibou

@kalbasit
Copy link
Member Author

@GrahamcOfBorg build bazel bazel.tests

@kalbasit
Copy link
Member Author

@GrahamcOfBorg build python3.pkgs.tensorflow

This might fail similarly to #74186, but it's working locally for me.

@flokli
Copy link
Contributor

flokli commented Nov 28, 2019 via email

@ofborg ofborg bot requested a review from mboes November 28, 2019 00:20
@kalbasit
Copy link
Member Author

Did you test it on the different Mac flavours mentioned in the bazel changelog?

I only have a Mac running Mojave. I will be testing on mine later today. I won't be able to test on other flavors though.

@kalbasit
Copy link
Member Author

It works well on my Mac.

@flokli
Copy link
Contributor

flokli commented Nov 28, 2019

Alright :-)

@flokli flokli merged commit c381d1c into NixOS:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

@mboes mboes Awaiting requested review from mboes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kalbasit @flokli